Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation on PHP 8.2 #11

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

localheinz
Copy link
Member

@localheinz localheinz commented Oct 26, 2023

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

This pull request

  • allows installation on PHP 8.2

Blocked by #13.
Blocked by #15.
Blocked by #12.

@froschdesign
Copy link
Member

@localheinz
I have rerun all the jobs, please check the new results.
Thanks in advance! 👍🏻

Signed-off-by: Andreas Möller <[email protected]>
@localheinz
Copy link
Member Author

I will open small pull requests to move forward here, @froschdesign!

Signed-off-by: Andreas Möller <[email protected]>
@localheinz localheinz mentioned this pull request Oct 30, 2023
1 task
@localheinz
Copy link
Member Author

@froschdesign @geerteltink @Ocramius

Passing now, but quite a number of unrelated changes.

If I look at the builds in the other pull requests, looks like current 2.10.x is also failing.

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @localheinz! Yes, indeed unrelated changes, but we're indeed trying to go green-to-green (as much as possible), as it is just going to be forgotten otherwise, sorry

@Ocramius Ocramius assigned Ocramius and unassigned localheinz Nov 2, 2023
@Ocramius Ocramius merged commit a291149 into laminas:2.10.x Nov 2, 2023
7 of 9 checks passed
@Ocramius Ocramius changed the title Enhancement: Allow installation on PHP 8.2 Allow installation on PHP 8.2 Nov 2, 2023
@localheinz localheinz deleted the feature/php8.2 branch November 2, 2023 20:59
@localheinz
Copy link
Member Author

Thank you, @froschdesign and @Ocramius!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants